-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pdfstream as cmap #283
Merged
Merged
Pdfstream as cmap #283
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
8ab2e28
Handle PDFStream as character map name in PDFCIDFont
john-redshelf c022358
Encapsulates character map name
fakabbir 8e4a82a
Corrects Indentation
fakabbir cc40af3
Removes @property, Adds docstring
fakabbir fa40043
Adds Test, Removes Unnecessary Assumptions
fakabbir b4c261b
Removes Code Comments
fakabbir f1a4dce
Adds Test Cases, Neater Code For CMap Assignment
fakabbir 5a0d8db
Adds decoder for OnebyteIdentityH/V instead of using default CMap
fakabbir 5b21098
Adds Test Case
fakabbir fe38695
Merge branch 'develop' into pdfstream-as-cmap
fakabbir 3125d36
Correct old test cases
fakabbir 3f0f05d
Merge branch 'pdfstream-as-cmap' of https://github.com/fakabbir/pdfmi…
fakabbir 3d549ea
Removes code comments
fakabbir abd685f
Corrects Code Comment
fakabbir 7c03d96
Corrects Comment
fakabbir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mentioned that DLIdent-* is not in the PDF reference manual. Did you find other pdf documentation that mentions this? If so, you could add a comment that refers to it such that we do not remove DLIdent-* by accident.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't seen any pdf with DLIdent-* but have included it due to its harmless nature. Will also include code comment to avoid DLIdent-* being removed by accident.