Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use conditional requirements to ensure "chardet" is always required on Python 3 #219

Merged
merged 1 commit into from
Oct 13, 2019
Merged

use conditional requirements to ensure "chardet" is always required on Python 3 #219

merged 1 commit into from
Oct 13, 2019

Commits on Jan 18, 2019

  1. use conditional requirements to ensure "chardet" listed as requiremen… 

    …t on Python 3 (fixes #213)

Previously "chardet" was added only added when setup.py was run with Python 3.
However wheels contain a static list of requirements and a wheel-based
install will never execute setup.py at installation time.

pdfminer.six uses universal wheels for Python 2 and Python 3 so the
requirements will always be wrong on one version (see #213).

The solution is to use conditional requirements as specified in PEP 496
which are evaluated at installation time.
    @FelixSchwarz
    FelixSchwarz committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    5ff84b8 View commit details
    Browse the repository at this point in the history