Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added v6 wallet balance api to SDK #170

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added v6 wallet balance api to SDK #170

wants to merge 4 commits into from

Conversation

navin-math
Copy link
Contributor

All Submissions:

  • Added get wallet balance api (v6) to SDK
  • Have you followed the guidelines in our Contributing document?
  • Have you read and signed the automated Contributor's License Agreement?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@blackduck-copilot
Copy link

blackduck-copilot bot commented May 4, 2022 •
edited
Loading

Black Duck Security Report

Merging #170 into master will not change security risk.

Added Components

Clean: 12

Click here to see full report

@CLAassistant
Copy link

CLAassistant commented May 4, 2022 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ chao-chang-paypay
❌ navin-math
You have signed the CLA already but the status is still pending? Let us recheck it.

codeclimate[bot]
codeclimate bot reviewed May 4, 2022
View reviewed changes
src/main/java/jp/ne/paypay/model/GetBalanceData.java
this.preference = preference;
}

@Override
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

src/main/java/jp/ne/paypay/model/GetWalletBalance.java
@@ -0,0 +1,99 @@
package jp.ne.paypay.model;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 10 locations. Consider refactoring.

src/main/java/jp/ne/paypay/api/WalletApi.java Outdated
null, localVarHeaderParams, localVarFormParams, localVarAuthNames);
}

private Call checkWalletBalanceValidateBeforeCall(String userAuthorizationId, Integer amount, String currency, ProductType productType) throws ApiException {

private Call validateCheckWalletBalanceParamsBeforeCall(String endpoint, String userAuthorizationId, Integer amount, String currency, ProductType productType) throws ApiException {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method validateCheckWalletBalanceParamsBeforeCall has 5 arguments (exceeds 4 allowed). Consider refactoring.

src/main/java/jp/ne/paypay/api/WalletApi.java
@@ -48,11 +49,9 @@ public void setApiClient(ApiClient apiClient) {
* @throws ApiException If fail to serialize the request body object

*/
private Call checkWalletBalanceCall(String userAuthorizationId, Integer amount, String currency,
private Call walletBalanceCall(String endpoint, String userAuthorizationId, Integer amount, String currency,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method walletBalanceCall has 5 arguments (exceeds 4 allowed). Consider refactoring.

src/main/java/jp/ne/paypay/model/Preference.java
this.cashbackAutoInvestment = cashbackAutoInvestment;
}

@Override
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method equals has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented May 4, 2022 •
edited
Loading

Code Climate has analyzed commit ae41ef6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 84.6% (5% is the threshold).

This pull request will bring the total coverage in the repository to 86.4% (0.0% change).

View more on Code Climate.

codeclimate[bot]
codeclimate bot reviewed May 4, 2022
View reviewed changes
src/main/java/jp/ne/paypay/model/GetWalletBalance.java
this.data = data;
}

@Override
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method equals has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

curtisfennerpaypay
curtisfennerpaypay reviewed May 10, 2022
View reviewed changes
Copy link
Contributor

@curtisfennerpaypay curtisfennerpaypay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the documentation in the readme and in the docs/ folder

src/test/java/jp/ne/paypay/api/WalletApiTest.java Outdated Show resolved Hide resolved
src/main/java/jp/ne/paypay/api/WalletApi.java Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate CodeClimate CodeClimate left review comments

@curtisfennerpaypay curtisfennerpaypay curtisfennerpaypay left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@navin-math @CLAassistant @curtisfennerpaypay @chao-chang-paypay