Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle no remote gracefully #75

Merged
merged 2 commits into from
Mar 17, 2024
Merged

Conversation

chme
Copy link
Contributor

@chme chme commented Mar 17, 2024

Fix for #24

With this change, git-changelog does not fail any more, if it cannot find a remote.
The generated changelog is not perfect. All the links have no target url.
Given that this is an edge case, maybe this is good enough?

Example output without remote:

## [1.0.0]() - 2024-03-02

<small>[Compare with 0.1.0]()</small>

### Features

- New feature for planned v1.0.0 ([3dba998]() by Christian Meffert).

## [0.1.0]() - 2024-03-02

<small>[Compare with first commit]()</small>

@pawamoy
Copy link
Owner

pawamoy commented Mar 17, 2024

Hmmm, I'm tempted to say LGTM, though maybe it's better if we handle this in templates too, to avoid links that lead to nowhere 🤔 OK you know what, let go with this, we can always change things if users request it. Thanks a lot!

tests/test_build.py Outdated Show resolved Hide resolved
Copy link
Owner

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pawamoy pawamoy merged commit 92f6f94 into pawamoy:main Mar 17, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants