Skip to content

Commit

Permalink
- disabled tests with dotnet#53018
Browse files Browse the repository at this point in the history
- disabled tests with dotnet#53591
- disabled tests with dotnet#53592
  • Loading branch information
pavelsavara committed Jun 2, 2021
1 parent 9d52c23 commit 951f5b9
Show file tree
Hide file tree
Showing 4 changed files with 47 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ public async Task SendAsync_SimpleGet_Success(Configuration.Http.RemoteServer re

[OuterLoop("Uses external servers")]
[Theory, MemberData(nameof(RemoteServersMemberData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/53018", TestPlatforms.Browser)]
public async Task SendAsync_MultipleRequestsReusingSameClient_Success(Configuration.Http.RemoteServer remoteServer)
{
using (HttpClient client = CreateHttpClientForRemoteServer(remoteServer))
Expand All @@ -113,6 +114,7 @@ public async Task SendAsync_MultipleRequestsReusingSameClient_Success(Configurat

[OuterLoop("Uses external servers")]
[Theory, MemberData(nameof(RemoteServersMemberData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/53018", TestPlatforms.Browser)]
public async Task GetAsync_ResponseContentAfterClientAndHandlerDispose_Success(Configuration.Http.RemoteServer remoteServer)
{
using (HttpClient client = CreateHttpClientForRemoteServer(remoteServer))
Expand Down Expand Up @@ -162,6 +164,7 @@ public async Task GetAsync_ServerNeedsAuthAndSetCredential_StatusCodeOK(Configur

[OuterLoop("Uses external servers")]
[Theory, MemberData(nameof(RemoteServersMemberData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/53018", TestPlatforms.Browser)]
public async Task GetAsync_ServerNeedsAuthAndNoCredential_StatusCodeUnauthorized(Configuration.Http.RemoteServer remoteServer)
{
using (HttpClient client = CreateHttpClientForRemoteServer(remoteServer))
Expand All @@ -177,6 +180,7 @@ public async Task GetAsync_ServerNeedsAuthAndNoCredential_StatusCodeUnauthorized
[OuterLoop("Uses external servers")]
[Theory]
[MemberData(nameof(RemoteServersAndHeaderEchoUrisMemberData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/53018", TestPlatforms.Browser)]
public async Task GetAsync_RequestHeadersAddCustomHeaders_HeaderAndEmptyValueSent(Configuration.Http.RemoteServer remoteServer, Uri uri)
{
if (IsWinHttpHandler && !PlatformDetection.IsWindows10Version1709OrGreater)
Expand All @@ -202,6 +206,7 @@ public async Task GetAsync_RequestHeadersAddCustomHeaders_HeaderAndEmptyValueSen

[OuterLoop("Uses external servers")]
[Theory, MemberData(nameof(RemoteServersHeaderValuesAndUris))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/53018", TestPlatforms.Browser)]
public async Task GetAsync_RequestHeadersAddCustomHeaders_HeaderAndValueSent(Configuration.Http.RemoteServer remoteServer, string name, string value, Uri uri)
{
using (HttpClient client = CreateHttpClientForRemoteServer(remoteServer))
Expand All @@ -220,6 +225,7 @@ public async Task GetAsync_RequestHeadersAddCustomHeaders_HeaderAndValueSent(Con

[OuterLoop("Uses external servers")]
[Theory, MemberData(nameof(RemoteServersAndHeaderEchoUrisMemberData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/53018", TestPlatforms.Browser)]
public async Task GetAsync_LargeRequestHeader_HeadersAndValuesSent(Configuration.Http.RemoteServer remoteServer, Uri uri)
{
// Unfortunately, our remote servers seem to have pretty strict limits (around 16K?)
Expand Down Expand Up @@ -287,6 +293,7 @@ public static IEnumerable<object[]> RemoteServersHeaderValuesAndUris()

[OuterLoop("Uses external servers")]
[Theory, MemberData(nameof(RemoteServersMemberData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/53018", TestPlatforms.Browser)]
public async Task GetAsync_ResponseHeadersRead_ReadFromEachIterativelyDoesntDeadlock(Configuration.Http.RemoteServer remoteServer)
{
using (HttpClient client = CreateHttpClientForRemoteServer(remoteServer))
Expand All @@ -312,6 +319,7 @@ public async Task GetAsync_ResponseHeadersRead_ReadFromEachIterativelyDoesntDead

[OuterLoop("Uses external servers")]
[Theory, MemberData(nameof(RemoteServersMemberData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/53018", TestPlatforms.Browser)]
public async Task SendAsync_HttpRequestMsgResponseHeadersRead_StatusCodeOK(Configuration.Http.RemoteServer remoteServer)
{
// Sync API supported only up to HTTP/1.1
Expand Down Expand Up @@ -522,6 +530,7 @@ public static IEnumerable<object[]> VerifyUploadServersStreamsAndExpectedData

[OuterLoop("Uses external servers")]
[Theory, MemberData(nameof(RemoteServersMemberData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/53018", TestPlatforms.Browser)]
public async Task PostAsync_CallMethod_NullContent(Configuration.Http.RemoteServer remoteServer)
{
using (HttpClient client = CreateHttpClientForRemoteServer(remoteServer))
Expand All @@ -543,6 +552,7 @@ public async Task PostAsync_CallMethod_NullContent(Configuration.Http.RemoteServ

[OuterLoop("Uses external servers")]
[Theory, MemberData(nameof(RemoteServersMemberData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/53018", TestPlatforms.Browser)]
public async Task PostAsync_CallMethod_EmptyContent(Configuration.Http.RemoteServer remoteServer)
{
using (HttpClient client = CreateHttpClientForRemoteServer(remoteServer))
Expand Down Expand Up @@ -574,6 +584,7 @@ public static IEnumerable<object[]> ExpectContinueVersion()
[OuterLoop("Uses external servers")]
[Theory]
[MemberData(nameof(ExpectContinueVersion))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/53018", TestPlatforms.Browser)]
public async Task PostAsync_ExpectContinue_Success(bool? expectContinue, Version version)
{
// Sync API supported only up to HTTP/1.1
Expand Down Expand Up @@ -613,6 +624,7 @@ public async Task PostAsync_ExpectContinue_Success(bool? expectContinue, Version

[OuterLoop("Uses external servers")]
[Theory, MemberData(nameof(RemoteServersMemberData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/53018", TestPlatforms.Browser)]
public async Task PostAsync_Redirect_ResultingGetFormattedCorrectly(Configuration.Http.RemoteServer remoteServer)
{
const string ContentString = "This is the content string.";
Expand Down Expand Up @@ -706,6 +718,7 @@ private async Task PostAsync_Redirect_LargePayload_Helper(Configuration.Http.Rem
#if !NETFRAMEWORK
[OuterLoop("Uses external servers")]
[Theory, MemberData(nameof(RemoteServersMemberData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/53018", TestPlatforms.Browser)]
public async Task PostAsync_ReuseRequestContent_Success(Configuration.Http.RemoteServer remoteServer)
{
const string ContentString = "This is the content string.";
Expand All @@ -726,6 +739,8 @@ public async Task PostAsync_ReuseRequestContent_Success(Configuration.Http.Remot

[OuterLoop("Uses external servers")]
[Theory, MemberData(nameof(HttpMethods))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/53018", TestPlatforms.Browser)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/53592", TestPlatforms.Browser)]
public async Task SendAsync_SendRequestUsingMethodToEchoServerWithNoContent_MethodCorrectlySent(
string method,
Uri serverUri)
Expand All @@ -746,6 +761,7 @@ public async Task SendAsync_SendRequestUsingMethodToEchoServerWithNoContent_Meth

[OuterLoop("Uses external servers")]
[Theory, MemberData(nameof(HttpMethodsThatAllowContent))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/53591", TestPlatforms.Browser)]
public async Task SendAsync_SendRequestUsingMethodToEchoServerWithContent_Success(
string method,
Uri serverUri)
Expand Down Expand Up @@ -775,6 +791,8 @@ public async Task SendAsync_SendRequestUsingMethodToEchoServerWithContent_Succes

[OuterLoop("Uses external servers")]
[Theory, MemberData(nameof(HttpMethodsThatDontAllowContent))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/53591", TestPlatforms.Browser)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/53592", TestPlatforms.Browser)]
public async Task SendAsync_SendRequestUsingNoBodyMethodToEchoServerWithContent_NoBodySent(
string method,
Uri serverUri)
Expand Down Expand Up @@ -820,6 +838,7 @@ public static IEnumerable<object[]> SendAsync_SendSameRequestMultipleTimesDirect

[OuterLoop("Uses external servers")]
[Theory, MemberData(nameof(SendAsync_SendSameRequestMultipleTimesDirectlyOnHandler_Success_MemberData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/53018", TestPlatforms.Browser)]
public async Task SendAsync_SendSameRequestMultipleTimesDirectlyOnHandler_Success(Configuration.Http.RemoteServer remoteServer, string stringContent, int startingPosition)
{
using (var handler = new HttpMessageInvoker(CreateHttpClientHandler()))
Expand Down Expand Up @@ -853,6 +872,7 @@ public async Task SendAsync_SendSameRequestMultipleTimesDirectlyOnHandler_Succes
[OuterLoop("Uses external servers")]
[Theory]
[MemberData(nameof(Http2Servers))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/53018", TestPlatforms.Browser)]
public async Task SendAsync_RequestVersion20_ResponseVersion20IfHttp2Supported(Uri server)
{
// Sync API supported only up to HTTP/1.1
Expand Down
21 changes: 21 additions & 0 deletions src/libraries/Common/tests/System/Net/Http/PostScenarioTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ public PostScenarioTest(ITestOutputHelper output) : base(output) { }
#if !NETFRAMEWORK
[OuterLoop("Uses external servers")]
[Theory, MemberData(nameof(RemoteServersMemberData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/53018", TestPlatforms.Browser)]
public async Task PostRewindableStreamContentMultipleTimes_StreamContentFullySent(Configuration.Http.RemoteServer remoteServer)
{
const string requestBody = "ABC";
Expand All @@ -55,6 +56,7 @@ public async Task PostRewindableStreamContentMultipleTimes_StreamContentFullySen
[OuterLoop("Uses external servers")]
[MemberData(nameof(RemoteServersMemberData))]
[ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsBrowserDomSupportedOrNotBrowser))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/53018", TestPlatforms.Browser)]
public async Task PostNoContentUsingContentLengthSemantics_Success(Configuration.Http.RemoteServer remoteServer)
{
await PostHelper(remoteServer, string.Empty, null,
Expand All @@ -66,6 +68,12 @@ await PostHelper(remoteServer, string.Empty, null,
[ActiveIssue("https://github.com/dotnet/runtime/issues/37669", TestPlatforms.Browser)]
public async Task PostEmptyContentUsingContentLengthSemantics_Success(Configuration.Http.RemoteServer remoteServer)
{
if (remoteServer.HttpVersion.Major >= 2 && PlatformDetection.IsBrowser)
{
// [ActiveIssue("https://github.com/dotnet/runtime/issues/53018", TestPlatforms.Browser)]
return;
}

await PostHelper(remoteServer, string.Empty, new StringContent(string.Empty),
useContentLengthUpload: true, useChunkedEncodingUpload: false);
}
Expand All @@ -75,6 +83,12 @@ public async Task PostEmptyContentUsingContentLengthSemantics_Success(Configurat
[ActiveIssue("https://github.com/dotnet/runtime/issues/37669", TestPlatforms.Browser)]
public async Task PostEmptyContentUsingChunkedEncoding_Success(Configuration.Http.RemoteServer remoteServer)
{
if (remoteServer.HttpVersion.Major >= 2 && PlatformDetection.IsBrowser)
{
// [ActiveIssue("https://github.com/dotnet/runtime/issues/53018", TestPlatforms.Browser)]
return;
}

await PostHelper(remoteServer, string.Empty, new StringContent(string.Empty),
useContentLengthUpload: false, useChunkedEncodingUpload: true);
}
Expand All @@ -84,6 +98,12 @@ public async Task PostEmptyContentUsingChunkedEncoding_Success(Configuration.Htt
[ActiveIssue("https://github.com/dotnet/runtime/issues/37669", TestPlatforms.Browser)]
public async Task PostEmptyContentUsingConflictingSemantics_Success(Configuration.Http.RemoteServer remoteServer)
{
if (remoteServer.HttpVersion.Major >= 2 && PlatformDetection.IsBrowser)
{
// [ActiveIssue("https://github.com/dotnet/runtime/issues/53018", TestPlatforms.Browser)]
return;
}

await PostHelper(remoteServer, string.Empty, new StringContent(string.Empty),
useContentLengthUpload: true, useChunkedEncodingUpload: true);
}
Expand Down Expand Up @@ -224,6 +244,7 @@ public async Task PostNonRewindableContentUsingAuth_PreAuthenticate_Success(Conf
[OuterLoop("Uses external servers")]
[MemberData(nameof(RemoteServersMemberData))]
[ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsBrowserDomSupportedOrNotBrowser))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/53018", TestPlatforms.Browser)]
public async Task PostAsync_EmptyContent_ContentTypeHeaderNotSent(Configuration.Http.RemoteServer remoteServer)
{
using (HttpClient client = CreateHttpClientForRemoteServer(remoteServer))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ public static IEnumerable<object[]> RemoteServersAndReadModes()
}
[OuterLoop("Uses external servers")]
[Theory, MemberData(nameof(RemoteServersAndReadModes))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/53018", TestPlatforms.Browser)]
public async Task GetStreamAsync_ReadToEnd_Success(Configuration.Http.RemoteServer remoteServer, int readMode)
{
using (HttpClient client = CreateHttpClientForRemoteServer(remoteServer))
Expand Down Expand Up @@ -127,6 +128,7 @@ public async Task GetStreamAsync_ReadToEnd_Success(Configuration.Http.RemoteServ

[OuterLoop("Uses external servers")]
[Theory, MemberData(nameof(RemoteServersMemberData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/53018", TestPlatforms.Browser)]
public async Task GetAsync_UseResponseHeadersReadAndCallLoadIntoBuffer_Success(Configuration.Http.RemoteServer remoteServer)
{
using (HttpClient client = CreateHttpClientForRemoteServer(remoteServer))
Expand All @@ -146,6 +148,7 @@ public async Task GetAsync_UseResponseHeadersReadAndCallLoadIntoBuffer_Success(C

[OuterLoop("Uses external servers")]
[Theory, MemberData(nameof(RemoteServersMemberData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/53018", TestPlatforms.Browser)]
public async Task GetAsync_UseResponseHeadersReadAndCopyToMemoryStream_Success(Configuration.Http.RemoteServer remoteServer)
{
using (HttpClient client = CreateHttpClientForRemoteServer(remoteServer))
Expand All @@ -170,6 +173,7 @@ public async Task GetAsync_UseResponseHeadersReadAndCopyToMemoryStream_Success(C

[OuterLoop("Uses external servers")]
[Theory, MemberData(nameof(RemoteServersMemberData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/53018", TestPlatforms.Browser)]
public async Task GetStreamAsync_ReadZeroBytes_Success(Configuration.Http.RemoteServer remoteServer)
{
using (HttpClient client = CreateHttpClientForRemoteServer(remoteServer))
Expand All @@ -185,6 +189,7 @@ public async Task GetStreamAsync_ReadZeroBytes_Success(Configuration.Http.Remote

[OuterLoop("Uses external servers")]
[Theory, MemberData(nameof(RemoteServersMemberData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/53018", TestPlatforms.Browser)]
public async Task ReadAsStreamAsync_Cancel_TaskIsCanceled(Configuration.Http.RemoteServer remoteServer)
{
var cts = new CancellationTokenSource();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1216,6 +1216,7 @@ await HttpAgnosticLoopbackServer.CreateClientAndServerAsync(
[OuterLoop("Uses external servers")]
[MemberData(nameof(VersionSelectionMemberData))]
[ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsBrowserDomSupportedOrNotBrowser))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/53018", TestPlatforms.Browser)]
public async Task SendAsync_CorrectVersionSelected_ExternalServer(Version requestVersion, HttpVersionPolicy versionPolicy, Version serverVersion, bool useSsl, object expectedResult)
{
RemoteServer remoteServer = null;
Expand Down

0 comments on commit 951f5b9

Please sign in to comment.