Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove critical section hooks to enhance MISRA conformance #4

Closed
pavel-kirienko opened this issue May 12, 2021 · 2 comments · Fixed by #7 or #10
Closed

Remove critical section hooks to enhance MISRA conformance #4

pavel-kirienko opened this issue May 12, 2021 · 2 comments · Fixed by #7 or #10
Labels
enhancement New feature or request
Milestone
v2.0

Comments

@pavel-kirienko
Copy link
Owner

Remove critical section enter/leave hooks:

o1heap/o1heap/o1heap.h

Lines 98 to 99 in bd93277

const O1HeapHook critical_section_enter,
const O1HeapHook critical_section_leave);

Equivalent behaviors can be implemented by wrapping library calls in custom user code instead.
@pavel-kirienko pavel-kirienko added the enhancement New feature or request label May 12, 2021
@pavel-kirienko pavel-kirienko added this to the v2.0 milestone May 12, 2021
pavel-kirienko added a commit that referenced this issue Oct 3, 2021
@pavel-kirienko
Remove critical section hooks; fix #4
85a31fb
@pavel-kirienko pavel-kirienko mentioned this issue Oct 3, 2021
Merged
pavel-kirienko added a commit that referenced this issue Oct 9, 2021
@pavel-kirienko
Version 2 with API enhancements (#7)
9daa66d 
* Actualize the tooling
* Add spelling dictionary
* Remove critical section hooks; fix #4
* Clean up redundant declarations
* Add support for O1HEAP_CONFIG_HEADER, fix #5
@jrahlf
Copy link

jrahlf commented Oct 20, 2021

The README should be changed accordingly, currently it says

In the case of concurrent environments, also pass pointers to the synchronization locking/unlocking functions -- they will be invoked by the library to facilitate atomic transactions. Alternatively, some applications (where possible) might benefit from using a separate heap per thread to avoid the synchronization overhead and reduce contention.

pavel-kirienko added a commit that referenced this issue Oct 21, 2021
@pavel-kirienko
Update README as suggested in #4
1320d50
@pavel-kirienko pavel-kirienko mentioned this issue Oct 21, 2021
Merged
@pavel-kirienko
Copy link
Owner Author

@jrahlf thanks! Fixed in #10

pavel-kirienko added a commit that referenced this issue Oct 21, 2021
@pavel-kirienko
Fix the README and update coverage measurement (#10)
4616230 
* Update README as suggested in #4

* Update CI configuration

* Enable sonarcloud on push, too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.0
2 participants
@jrahlf @pavel-kirienko