Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dtslinting #1158

Merged
merged 4 commits into from
Oct 8, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,6 @@ jobs:

- name: Run lint
run: npm run lint

- name: Run dtslint
run: npm run dtslint
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
"rimraf": "^3.0.0",
"sinon": "^9.0.1",
"sinon-chai": "^3.3.0",
"typescript": "~4.4.3",
"upath": "^1.2.0"
},
"files": [
Expand Down
2 changes: 1 addition & 1 deletion types/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import * as fs from "fs";
import { EventEmitter } from "events";
import { Matcher } from 'anymatch'
import { Matcher } from 'anymatch';

export class FSWatcher extends EventEmitter implements fs.FSWatcher {
options: WatchOptions;
Expand Down
4 changes: 3 additions & 1 deletion types/test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,9 @@ watcher.add(["new-file-2", "new-file-3", "**/other-file*"]);
watcher.unwatch("new-file*");

// Only needed if watching is `persistent: true`.
watcher.close();
(async () => {
await watcher.close();
})();

// One-liner
chokidar
Expand Down
Loading