Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: simpler eslint config (no custom babel) #185

Merged
merged 2 commits into from
Dec 28, 2021
Merged

build: simpler eslint config (no custom babel) #185

merged 2 commits into from
Dec 28, 2021

Conversation

ccorda
Copy link
Contributor

@ccorda ccorda commented Dec 18, 2021

See parent issue for a bit more. Leaning on next configs vs. specifying our own.

closes #184

@vercel
Copy link

vercel bot commented Dec 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/patronage/bubs-next/GrRMTfUc1hfSm9Y2GkZB6HBmsJhu
✅ Preview: https://bubs-next-git-184-babel-patronage.vercel.app

@ccorda ccorda changed the title simpler eslint config (no custom babel) build: simpler eslint config (no custom babel) Dec 27, 2021
* main:
  chore: node minor dep upgrades (#188)
  docs: env variable with graphcdn
  fix bug in postheader loading wrong scss file

# Conflicts:
#	website/package.json
Copy link
Member

@kylehotchkiss kylehotchkiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but one thought, should we just use the eslint that the upstream Next package requires? Or does Next.js want to see Eslint loaded in our package.json in order to activate it?

@ccorda
Copy link
Contributor Author

ccorda commented Dec 27, 2021

I think it installs it:

If either of the two configuration options are selected, Next.js will automatically install eslint and eslint-config-next as development dependencies in your application and create an .eslintrc.json file in the root of your project that includes your selected configuration.

@ccorda
Copy link
Contributor Author

ccorda commented Dec 28, 2021

Confirmed in a sandbox that a default next install adds the following:

package.json:

  "devDependencies": {
    "eslint": "8.5.0",
    "eslint-config-next": "12.0.7"
  }

.eslintrc.json

{
  "extends": "next/core-web-vitals"
}

@ccorda ccorda merged commit 76e4a6d into main Dec 28, 2021
@ccorda ccorda deleted the 184-babel branch December 28, 2021 00:08
ccorda added a commit that referenced this pull request Dec 28, 2021
* main:
  simpler eslint config (no custom babel) (#185)
  chore: node minor dep upgrades (#188)
  docs: env variable with graphcdn
  fix bug in postheader loading wrong scss file
  fix env.sample domain for graphcdn
  fix: meta not respecting social variables, customized title (#176)
  feat: log wp admin users into front-end preview mode (#173)
  fix: Get stylelint working again (#182)
  feat: Next 12 upgrade (#180)
  feat: bumping husky to version 7 (#179)
  resolve bug where clicking 'view' in wp-admin leads to a broken redirect (#165)
  feat: new convenience plugins in wordpress admin (#166)
  feat: theme mod instead of acf options for preview mode url (#163)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify eslint parsing
2 participants