Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug with SEO title precedence over page title #172

Closed
ccorda opened this issue Oct 13, 2021 · 0 comments
Closed

Bug with SEO title precedence over page title #172

ccorda opened this issue Oct 13, 2021 · 0 comments
Assignees
@ccorda
Labels
seo

Comments

@ccorda
Copy link
Contributor

ccorda commented Oct 13, 2021

The title isn't rendering if populated via yoast:
title: seo.title || title ? ${title} ${META.titleAppend} : '',

This fixes:

  let generatedTitle = title ? `${title} ${META.titleAppend}` : '';

  let seoSettings = {
    title: seo?.title || generatedTitle,
@ccorda ccorda added the seo label Oct 13, 2021
@ccorda ccorda self-assigned this Oct 13, 2021
ccorda added a commit that referenced this issue Oct 26, 2021
@ccorda
SEO docs, fix bugs
82e4178 
refs #174
refs #172
@ccorda ccorda mentioned this issue Oct 26, 2021
Merged
@ccorda ccorda mentioned this issue Nov 22, 2021
Open
ccorda added a commit that referenced this issue Nov 26, 2021
@ccorda
fix: meta not respecting social variables, customized title (#176)
c041759 
* SEO docs, fix bugs

refs #174
refs #172

* helper function for checking image paths on og images

* use og (facebook) and twitter values if they exist

refs #177

* cleaner implementation of proxyImages (and variable to enable)

* favicon from config.

closes #183
@ccorda ccorda closed this as completed Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ccorda ccorda

Labels
seo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ccorda