My changes to periscope #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not a problem, as when checking out files on Windows git will convert the EOLs automatically to Windows ones.
…or the subtitles This avoids overwriting a subtitle if it was already there
…ly (eg: BierDopje can't be imported on Mac OS X)
- periscope.py has a new attemptDownloadSubtitleText which returns the content of the subtitle instead of writing it to the disk - SubtitleDB.createFile() has been modified to be able to download and write any type of file. Plugins can specify 'forceType' == one_of([ 'zip', 'gz', 'srt', 'sub' ]) (inside the returned subtitle object) to tell explicitly which type of file they provide to the createFile method
…ubtitleDB.createFile()
…erywhere in the world...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains all my changes to periscope, in no order: