replace pythonrouge with rouge #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces pythonrouge package with the rouge package, a full python only re-implementation. Unfortunately, the new package does not have identical scores to the original perl version of rouge (see pltrdy/rouge#2), but the scores are close enough, especially when used as input to a model. Google also does something like this in their seq2seq model using a rough re-implementation of rouge.
This provides some speed gains since we don't have to go back and forth between perl/python. I found that while trying to use this model on a larger dataset, speed was a big issue, even during prediction time.