Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permissions configuration in README example #285

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

zimagen
Copy link
Contributor

@zimagen zimagen commented Aug 28, 2024

This PR addresses an issue with the example workflow configuration in the README, which doesn't work correctly on new repositories with default settings. The problem is due to improper placement of the permissions block and missing required permissions. This PR proposes the following changes:

  1. Moved the permissions block from the step level to the job level.
  2. Added the pull-requests: read permission, which is necessary for the action to read PR labels.

These changes ensure that the example in the README accurately reflects the correct configuration for the action to work as expected.

@pascalgn pascalgn merged commit 31a90c6 into pascalgn:main Sep 22, 2024
1 check passed
@pascalgn
Copy link
Owner

Thanks for the PR, it's merged now! 👍

github-actions bot referenced this pull request in KernelPanicAUS/aws-s3-lambda-dynamodb-batch-loader Sep 22, 2024
| Package | Type | Update | Change |
|---|---|---|---|
| [pascalgn/automerge-action](https://redirect.github.com/pascalgn/automerge-action) | action | patch | `v0.16.3` -> `v0.16.4` |

---

### Release Notes

<details>
<summary>pascalgn/automerge-action (pascalgn/automerge-action)</summary>

### [`v0.16.4`](https://redirect.github.com/pascalgn/automerge-action/releases/tag/v0.16.4): Release 0.16.4

[Compare Source](https://redirect.github.com/pascalgn/automerge-action/compare/v0.16.3...v0.16.4)

#### What's Changed

-   Allow set of `MAX_PR_COUNT` from environment by [@&#8203;agershman](https://redirect.github.com/agershman) in [https://github.com/pascalgn/automerge-action/pull/286](https://redirect.github.com/pascalgn/automerge-action/pull/286)
-   Fix permissions configuration in README example by [@&#8203;zimagen](https://redirect.github.com/zimagen) in [https://github.com/pascalgn/automerge-action/pull/285](https://redirect.github.com/pascalgn/automerge-action/pull/285)

#### New Contributors

-   [@&#8203;agershman](https://redirect.github.com/agershman) made their first contribution in [https://github.com/pascalgn/automerge-action/pull/286](https://redirect.github.com/pascalgn/automerge-action/pull/286)
-   [@&#8203;zimagen](https://redirect.github.com/zimagen) made their first contribution in [https://github.com/pascalgn/automerge-action/pull/285](https://redirect.github.com/pascalgn/automerge-action/pull/285)

**Full Changelog**: pascalgn/automerge-action@v0.16.3...v0.16.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/KernelPanicAUS/aws-s3-lambda-dynamodb-batch-loader).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiYXV0b21lcmdlIiwiZGVwZW5kZW5jeS11cGRhdGUiLCJyZW5vdmF0ZSJdfQ==-->
truecharts-admin referenced this pull request in truecharts/charts Sep 23, 2024
…novate (#26769)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[pascalgn/automerge-action](https://redirect.github.com/pascalgn/automerge-action)
| action | patch | `v0.16.3` -> `v0.16.4` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>pascalgn/automerge-action (pascalgn/automerge-action)</summary>

###
[`v0.16.4`](https://redirect.github.com/pascalgn/automerge-action/releases/tag/v0.16.4):
Release 0.16.4

[Compare
Source](https://redirect.github.com/pascalgn/automerge-action/compare/v0.16.3...v0.16.4)

#### What's Changed

- Allow set of `MAX_PR_COUNT` from environment by
[@&#8203;agershman](https://redirect.github.com/agershman) in
[https://github.com/pascalgn/automerge-action/pull/286](https://redirect.github.com/pascalgn/automerge-action/pull/286)
- Fix permissions configuration in README example by
[@&#8203;zimagen](https://redirect.github.com/zimagen) in
[https://github.com/pascalgn/automerge-action/pull/285](https://redirect.github.com/pascalgn/automerge-action/pull/285)

#### New Contributors

- [@&#8203;agershman](https://redirect.github.com/agershman) made their
first contribution in
[https://github.com/pascalgn/automerge-action/pull/286](https://redirect.github.com/pascalgn/automerge-action/pull/286)
- [@&#8203;zimagen](https://redirect.github.com/zimagen) made their
first contribution in
[https://github.com/pascalgn/automerge-action/pull/285](https://redirect.github.com/pascalgn/automerge-action/pull/285)

**Full Changelog**:
pascalgn/automerge-action@v0.16.3...v0.16.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://redirect.github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC45My4yIiwidXBkYXRlZEluVmVyIjoiMzguOTMuMiIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6WyJhdXRvbWVyZ2UiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants