Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add containerized hosting #988

Merged
merged 9 commits into from
May 30, 2019
Merged

Add containerized hosting #988

merged 9 commits into from
May 30, 2019

Conversation

zfields
Copy link
Contributor

@zfields zfields commented May 20, 2019

No description provided.

@zfields zfields requested review from monkbroc and rickkas7 May 20, 2019 22:35
@zfields zfields self-assigned this May 20, 2019
@zfields zfields requested a review from moors7 May 20, 2019 22:47
@towynlin
Copy link
Contributor

Regarding that long docker run command — it's magical tribal knowledge that's not obvious, therefore (1) thank you so much for putting it in the README 👍, and (2) please add a script to the scripts folder so a human doesn't even need to copy paste from the README.

monkbroc
monkbroc approved these changes May 21, 2019
View reviewed changes
Copy link
Member

@monkbroc monkbroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting together and demoing the containerized docs Zak!

@zfields zfields requested a review from towynlin May 22, 2019 22:19
@towynlin
Copy link
Contributor

Thanks! At a glance looks fine — I'll try to run it within the hour.

@towynlin
Copy link
Contributor

towynlin commented May 22, 2019 •
edited
Loading

Running source scripts/gen-docker-alias.sh crashes my terminal!

Running scripts/gen-docker-alias.sh outputs:

\
`getopt --test` failed in this environment.
Please confirm "GNU getopt" is installed on this device.

I'm running bash on macOS Mojave 10.14.5 in the normal Terminal app.

@zfields
Copy link
Contributor Author

zfields commented May 23, 2019

That's wild! Looks like the script is very Linux centric at this moment.

The error message is accurate. You will need to brew install gnu-getopt before the script will ever work, but holy cow that is a failure condition we cannot tolerate.

zfields and others added 4 commits May 25, 2019 11:23
@zfields
Merge pull request #990 from particle-iot/docker-suggestion
b850994 
Adds simple script to call `docker run` similar to server.js
@rickkas7 @zfields
Fix redirect
45e6e29 
The redirect to /support/general/pricing was missing the leading slash
@rickkas7 @zfields
Minor edits
6d60f7c 
- Gen 3 lists wrong SPI SS pin in several places (ch30306)
- Gen 3 SPI slave only on SPI1 (ch33428)
- Gen 3 SPI speeds different than Gen 2
- Billing had some outdated info (ch33092)
- UDP session length changed (ch32814)
@zfields
clean-up after PR merge
49df842 
`$@` is a bash specific construct, so that was reflected in the new script.
https://stackoverflow.com/questions/3898665/what-is-in-bash

removed the script being replaced

updated documentation
@zfields
Copy link
Contributor Author

zfields commented May 26, 2019

Looks like containerized hosting on Mac may not be an option, until this open Docker for Mac issue gets resolved.
docker/for-mac#2965

@towynlin
Copy link
Contributor

towynlin commented May 29, 2019 •
edited
Loading

If you add language to the readme about the docker for mac issue, we could go ahead and merge this. It's additive, not destructive. Please structure the readme so a user skimming the thing just trying to quickly get started with the docs doesn't go down the wrong path — on linux, containerized hosting; on mac, npm start; on windows whatever you recommend since I haven't tried it. npm start should work on all platforms, containerized hosting works on linux not on mac.

@zfields
Copy link
Contributor Author

zfields commented May 29, 2019 •
edited
Loading

Awesome! I'll make the update and have you review before merging.

EDIT: I ended up supplying a note that containerized hosting only works on Linux at this time. Can you have a look and see if you dig it?

@zfields zfields merged commit 71a0d7a into master May 30, 2019
@zfields zfields deleted the docker branch May 30, 2019 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monkbroc monkbroc monkbroc approved these changes

@rickkas7 rickkas7 Awaiting requested review from rickkas7

@moors7 moors7 Awaiting requested review from moors7

@towynlin towynlin Awaiting requested review from towynlin

Assignees

@zfields zfields

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zfields @towynlin @monkbroc @rickkas7