Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trivial] create inner loop pattern tag manually #1087

Merged
merged 3 commits into from
May 22, 2024

Conversation

Yurlungur
Copy link
Collaborator

@Yurlungur Yurlungur commented May 22, 2024

PR Summary

My "automatic" loop pattern fix in PR #1078 had an unexpected effect. Inner loop pattern tags, on some builds in riot, are now not being properly resolved on device. I think this is related to #321 and #319, though I'm not sure why constexpr isn't sufficient to make the tags get captured. The trivial solution, implemented here, is to just make the macro call the tag constructor manually. This only needs to be done for InnerLoopPatternTVR.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@Yurlungur Yurlungur added the bug Something isn't working label May 22, 2024
@Yurlungur Yurlungur self-assigned this May 22, 2024
@Yurlungur Yurlungur enabled auto-merge May 22, 2024 17:37
Copy link
Collaborator

@lroberts36 lroberts36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yurlungur Yurlungur disabled auto-merge May 22, 2024 18:55
@Yurlungur Yurlungur enabled auto-merge May 22, 2024 18:55
@Yurlungur Yurlungur merged commit af3777a into develop May 22, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants