Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default loop patterns back into the global par_loops #1066

Merged
merged 7 commits into from
Apr 29, 2024

Conversation

Yurlungur
Copy link
Collaborator

@Yurlungur Yurlungur commented Apr 29, 2024

PR Summary

We discussed multiple times in the parthenon calls that we would like to reduce boiler plate, and re-introduce global par loops that don't require specifying manually an execution space or loop pattern. Here I re-introduce these defaults to reduce boiler plate.

Note that the tasking @jdolence has been working on may conflict, if he's using execution spaces for threads. (Though presumably that conflict can be resolved.)

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@Yurlungur Yurlungur added enhancement New feature or request Kokkos Kokkos infrastructure/feature related C++17 labels Apr 29, 2024
@Yurlungur Yurlungur self-assigned this Apr 29, 2024
Copy link
Collaborator

@bprather bprather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like having these. I haven't forgotten about upstreaming integrated par_for+IndexRange but this should be completely orthogonal to that.

@Yurlungur Yurlungur merged commit 594b4e2 into develop Apr 29, 2024
49 checks passed
@Yurlungur Yurlungur deleted the jmm/default-loop-patterns branch April 30, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++17 enhancement New feature or request Kokkos Kokkos infrastructure/feature related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants