Vector history not being output if no scalar history present #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yurlungur
approved these changes
Apr 17, 2024
brryan
commented
Apr 17, 2024
| labels[hist_var.hst_op].push_back(hist_var.label); | ||
| // Check if the package has enrolled scalar history functions which are stored in the | ||
| // Params under the `hist_param_key` name. | ||
| if (params.hasKey(hist_param_key)) { |
There was a problem hiding this comment.
Only potential change in behavior is that, even if no history vars are enrolled, we still update md_base if it was empty or if it had a different size than pm->block_list. I think this is fine because codes shouldn't be designed around not updating this variable during history output only if no history variables were requested.
I also now update md_base only once for all packages rather than inside the for (const auto &pkg : packages) loop.
pgrete
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Running vector history downstream, I just ran into another bug: If a package only has vector history outputs enrolled, these will be ignored by an earlier
continuestatement in the loop over history variables triggered by a lack of scalar history outputs.Trivial fix, works downstream for me.
PR Checklist