Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: precipitator #100

Draft
wants to merge 327 commits into
base: main
Choose a base branch
from
Draft

WIP: precipitator #100

wants to merge 327 commits into from

Conversation

BenWibking
Copy link
Contributor

@BenWibking BenWibking commented Feb 22, 2024

This adds the precipitator pgen.
(New PR to avoid issues with actions running on forks.)

This PR depends on:

Parthenon PRs:

@BenWibking
Copy link
Contributor Author

@par-hermes format

@BenWibking
Copy link
Contributor Author

@pgrete In order to be able to merge this PR eventually, I need to either copy and paste the cooling code with my modifications into the pgen, or the cooling code should allow the pgen to provide a callback function for special modifications (like changing the cooling curve as a function of location in the box).

I assume the former is the preferred option. However, I still would like to avoid copying the cooling code completely. Is there a limited subset of the cooling code that I should copy into the pgen? Also, I can't hook into the task manager from the pgen, so I assume I should make it operator split in the same way I've implemented the turbulence driving source term?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pgrete I think this has been made obsolete by the new way you've implemented histograms in Parthenon, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant