fix: Invalid push notification tokens are not cleaned up from database for FCM API v2 #9173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! |
mtrezza
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## alpha #9173 +/- ##
==========================================
- Coverage 94.15% 94.14% -0.01%
==========================================
Files 186 186
Lines 14727 14729 +2
==========================================
+ Hits 13866 13867 +1
- Misses 861 862 +1 ☔ View full report in Codecov by Sentry. |
parseplatformorg
pushed a commit
that referenced
this pull request
Jul 1, 2024
# [7.1.0-alpha.13](7.1.0-alpha.12...7.1.0-alpha.13) (2024-07-01) ### Bug Fixes * Invalid push notification tokens are not cleaned up from database for FCM API v2 ([#9173](#9173)) ([284da09](284da09))
|
🎉 This change has been released in version 7.1.0-alpha.13 |
parseplatformorg
pushed a commit
that referenced
this pull request
Jul 9, 2024
# [7.2.0-beta.1](7.1.0...7.2.0-beta.1) (2024-07-09) ### Bug Fixes * Invalid push notification tokens are not cleaned up from database for FCM API v2 ([#9173](#9173)) ([284da09](284da09)) ### Features * Add support for dot notation on array fields of Parse Object ([#9115](#9115)) ([cf4c880](cf4c880)) * Upgrade to @parse/push-adapter 6.4.0 ([#9182](#9182)) ([ef1634b](ef1634b)) * Upgrade to Parse JS SDK 5.3.0 ([#9180](#9180)) ([dca187f](dca187f))
|
🎉 This change has been released in version 7.2.0-beta.1 |
parseplatformorg
pushed a commit
that referenced
this pull request
Jul 9, 2024
# [7.2.0](7.1.0...7.2.0) (2024-07-09) ### Bug Fixes * Invalid push notification tokens are not cleaned up from database for FCM API v2 ([#9173](#9173)) ([284da09](284da09)) ### Features * Add support for dot notation on array fields of Parse Object ([#9115](#9115)) ([cf4c880](cf4c880)) * Upgrade to @parse/push-adapter 6.4.0 ([#9182](#9182)) ([ef1634b](ef1634b)) * Upgrade to Parse JS SDK 5.3.0 ([#9180](#9180)) ([dca187f](dca187f))
|
🎉 This change has been released in version 7.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Closes: #9085
Approach
The references on how to manage the token responses:
Tokens will be cleaned up in the following cases:
messaging/registration-token-not-registeredmessaging/invalid-registration-tokenmessaging/invalid-argumentbut only if error message isThe registration token is not a valid FCM registration token--> I tested this out; this error response is received if the token format itself is invalid, for example a token value ofinvalid_test_tokenTasks