This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Refactor BlockBuilder::propose_with
#14405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
A0-please_review
gavofyork
approved these changes
Jun 18, 2023
skunert
approved these changes
Jun 19, 2023
bkchr
approved these changes
Jun 19, 2023
Co-authored-by: Bastian Köcher <git@kchr.de>
|
bot merge |
|
Waiting for commit status. |
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* Add log target Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Factor out apply_inherents Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Factor out apply_extrinsics Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Factor out print_summary Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Pimp print_summary Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Cleanup Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Fixes Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update client/basic-authorship/src/basic_authorship.rs Co-authored-by: Bastian Köcher <git@kchr.de> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Bastian Köcher <git@kchr.de>
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-controversial refactoring of the BlockBuilder to make #14275 easier to review.
Changes:
propose_withintoapply_inherents,apply_extrinsicisandprint_summary.no extrinsicsinstead ofextrinsics (0): []when there are none.