Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update platform-editor #888

Merged
merged 1 commit into from
May 9, 2024
Merged

update platform-editor #888

merged 1 commit into from
May 9, 2024

Conversation

irahopkinson
Copy link
Contributor

@irahopkinson irahopkinson commented May 9, 2024 •
edited
Loading

  • retain block format on enter key
  • no toolbar when read-only
  • update dependencies

This change is Reviewable

@irahopkinson
update platform-editor
232d79b 
- retain block format on enter key
- no toolbar when read-only
- update dependencies
@irahopkinson irahopkinson enabled auto-merge (squash) May 9, 2024 01:35
lyonsil
lyonsil approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@lyonsil lyonsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@irahopkinson irahopkinson merged commit 65aec40 into main May 9, 2024
7 checks passed
@irahopkinson irahopkinson deleted the editor-update branch May 9, 2024 13:04
@tjcouch-sil
Copy link
Member

tjcouch-sil commented May 13, 2024 •
edited
Loading

Ooh no toolbar on read-only! Does that mean we can remove the extra css I added to remove it manually? Some of this stuff:
https://github.com/paranext/paratext-bible-extensions/blob/main/src/paratext-bible-text-collection/src/web-views/editor-styles/_editor-overrides.scss#L8

@irahopkinson
Copy link
Contributor Author

Yep, I was motivated to do it sooner in core because #542 accidentally removed the CSS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyonsil lyonsil lyonsil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irahopkinson @tjcouch-sil @lyonsil