Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull out electron-builder config #82

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Conversation

irahopkinson
Copy link
Contributor

@irahopkinson irahopkinson commented Mar 16, 2023

I've tested this on Windows and Linux production builds.

This should probably be merged after #72 since that moves cSpell settings from .vscode/settings.json to cspell.json and I'll need to rebase and make the same change here.

Resolves #81.


This change is Reviewable

tjcouch-sil
tjcouch-sil previously approved these changes Mar 16, 2023
Copy link
Member

@tjcouch-sil tjcouch-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Thanks for the great work on this! I like it. We can merge this in before events if you want; like we said, we should all be capable of doing merges well ;)

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @irahopkinson)


electron-builder.json5 line 1 at r1 (raw file):

/**

I have never heard of json5 files before! I like it :)

Copy link
Member

@tjcouch-sil tjcouch-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @irahopkinson)

@irahopkinson irahopkinson merged commit 7ee8912 into main Mar 16, 2023
@irahopkinson irahopkinson deleted the 81-electron-builder-config branch March 16, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull out electron-builder config
2 participants