#772: Incorporate hamburger menu in web view component #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… hooked it up to be used in the toolbar and platform-tab-title.component.
…containerRef to determine position of menu. Added some "dummy" web view menu data for resourceViewer.react Modified createRCDockTabFromTabInfo to pass web view type to the title and made the title's icon into a menu button (instead of the hamburger icon).
tombogle
force-pushed
the
722-hamburger-menus-on-webviews
branch
from
ae68b8a
to
aa4c3dd
Compare
…n-webviews # Conflicts: # lib/platform-bible-react/dist/index.cjs # lib/platform-bible-react/dist/index.cjs.map # lib/platform-bible-react/dist/index.js # lib/platform-bible-react/dist/index.js.map # lib/platform-bible-react/src/components/toolbar.component.tsx # src/extension-host/data/menu.data.json REVIEW: Had to change the name of the resource viewer extension to use camelCase (resource-viewer => resourceViewer) in the manifest. TJ and Matt need to discuss this further.
…dded positioning logic based on containerRef (eliminating the need for an offset-based approach. Also fixed layout of icon in webview title bar.
tjcouch-sil
previously approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Reviewed 1 of 12 files at r1, 16 of 16 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
# Conflicts: # lib/platform-bible-react/dist/index.cjs # lib/platform-bible-react/dist/index.cjs.map # lib/platform-bible-react/dist/index.js # lib/platform-bible-react/dist/index.js.map
tjcouch-sil
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… hooked it up to be used in the toolbar and platform-tab-title.component.
This change is