Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the webview service to use the new service pattern #640

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Update the webview service to use the new service pattern #640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f8c68cd
Update the webview service to use the new service pattern
lyonsil Nov 13, 2023
a7cc3d2
Fix problems
lyonsil Nov 13, 2023
4feb455
PR feedback and fix one extension I missed earlier
lyonsil Nov 14, 2023
f07f18d
Missed the d.ts update
lyonsil Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/src/hello-someone/hello-someone.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import type {
WebViewContentType,
WebViewDefinition,
SavedWebViewDefinition,
} from 'shared/data/web-view.model';
} from 'shared/models/web-view.model';
import type { PeopleData, PeopleDataMethods, PeopleDataTypes, Person } from 'hello-someone';
import type { DataProviderUpdateInstructions } from 'shared/models/data-provider.model';
import type IDataProviderEngine from 'shared/models/data-provider-engine.model';
Expand Down
2 changes: 1 addition & 1 deletion extensions/src/hello-world/hello-world.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import type {
WebViewContentType,
WebViewDefinition,
SavedWebViewDefinition,
} from 'shared/data/web-view.model';
} from 'shared/models/web-view.model';
import type { IWebViewProvider } from 'shared/models/web-view-provider.model';
import type PapiEventEmitter from 'shared/models/papi-event-emitter.model';
import type { HelloWorldEvent } from 'hello-world';
Expand Down
2 changes: 1 addition & 1 deletion extensions/src/hello-world/web-views/hello-world.web-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import {
import { Key, useCallback, useEffect, useMemo, useRef, useState } from 'react';
import type { HelloWorldEvent } from 'hello-world';
import type { DialogTypes } from 'renderer/components/dialogs/dialog-definition.model';
import type { WebViewProps } from 'shared/data/web-view.model';
import type { WebViewProps } from 'shared/models/web-view.model';
import Clock from './components/clock.component';
import Logo from '../assets/offline.svg';

Expand Down
2 changes: 1 addition & 1 deletion extensions/src/resource-viewer/resource-viewer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import type {
GetWebViewOptions,
SavedWebViewDefinition,
WebViewDefinition,
} from 'shared/data/web-view.model';
} from 'shared/models/web-view.model';
import type { ExecutionActivationContext } from 'extension-host/extension-types/extension-activation-context.model';
import resourceViewerWebView from './resource-viewer.web-view?inline';
import resourceViewerWebViewStyles from './resource-viewer.web-view.scss?inline';
Expand Down
2 changes: 1 addition & 1 deletion extensions/src/resource-viewer/resource-viewer.web-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { useProjectData, useSetting } from 'papi-frontend/react';
import { ScriptureReference } from 'papi-components';
import { JSX, useMemo } from 'react';
import UsxEditor from 'usxeditor';
import type { WebViewProps } from 'shared/data/web-view.model';
import type { WebViewProps } from 'shared/models/web-view.model';

/** Characteristics of a marker style */
interface StyleInfo {
Expand Down
Loading