Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop doing cross builds on release #539

Merged
merged 1 commit into from
Oct 9, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:

strategy:
matrix:
os: [macos-latest, ubuntu-latest]
os: [windows-latest, macos-latest, ubuntu-latest]
dotnet_version: [7.0.x]
node_version: [18.x]

Expand All @@ -43,11 +43,15 @@ jobs:
npm install
npm run build

- name: dotnet build - Windows on macOS
if: ${{ matrix.os == 'macos-latest' }}
run: npm run build:data-release:windows
- name: Publish releases - Windows
# If the branch is labeled as a release version (e.g. "release/v1.2.3"),
if: ${{ matrix.os == 'windows-latest' && startsWith(github.ref, 'refs/heads/release/v') && contains(github.ref, '.') }}
env:
# This is used for uploading release assets to github
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: npm exec electron-builder -- --publish always --win

- name: Publish releases - Windows and macOS
- name: Publish releases - macOS
# If the branch is labeled as a release version (e.g. "release/v1.2.3"),
if: ${{ matrix.os == 'macos-latest' && startsWith(github.ref, 'refs/heads/release/v') && contains(github.ref, '.') }}
env:
Expand All @@ -58,8 +62,7 @@ jobs:
# CSC_KEY_PASSWORD: ${{ secrets.CSC_KEY_PASSWORD }}
# This is used for uploading release assets to github
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
npm exec electron-builder -- --publish always --win --mac
run: npm exec electron-builder -- --publish always --mac

- name: Publish releases - Linux
# If the branch is labeled as a release version (e.g. "release/v1.2.3"),
Expand All @@ -69,8 +72,7 @@ jobs:
USE_HARD_LINKS: false
# This is used for uploading release assets to github
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
npm exec electron-builder -- --publish always --linux
run: npm exec electron-builder -- --publish always --linux

# Enable tmate debugging of manually-triggered workflows if the input option was provided
- name: Setup tmate session
Expand Down