Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added extension host process that launches from main process #29

Merged
merged 15 commits into from
Mar 8, 2023

Conversation

tjcouch-sil
Copy link
Member

@tjcouch-sil tjcouch-sil commented Feb 15, 2023

  • Added extension host process that launches from main process. Has some test command handlers
    • Watchers automatically restart it with nodemon
    • Extension host has its own webpack configuration and exports to its own js bundle
    • When launched through VS Code, breakpoints hit on both main and extension host
    • When launched outside of VS Code, extension host console logs and errors are logged with {eh} prefix and {/eh} postfix
  • Added localStorage polyfill on the Node processes. Goes to %appdata%/paranext-core
  • Added src/client folder for shared modules between the renderer and the extension host
  • Added src/node folder for shared modules between main and extension host
  • Added retrying websocket connection on clients
  • Removed request registrations on client disconnect
  • Split out WebSocket in ClientNetworkConnector.ts into WebSocketFactory.ts that loads browser WebSocket in renderer and ws's WebSocket in Node (extension host)
  • Various fixes

Relates to #7 and #16

@tjcouch-sil tjcouch-sil marked this pull request as ready for review March 1, 2023 22:44
Copy link
Contributor

@irahopkinson irahopkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all your good work on this. I've done a first pass over this to keep it moving forward.

.vscode/launch.json Outdated Show resolved Hide resolved
src/shared/services/NetworkService.ts Outdated Show resolved Hide resolved
src/shared/services/CommandService.ts Outdated Show resolved Hide resolved
src/renderer/App.tsx Outdated Show resolved Hide resolved
src/node/util/util.ts Outdated Show resolved Hide resolved
src/main/main.ts Show resolved Hide resolved
src/main/services/ServerNetworkConnector.ts Show resolved Hide resolved
src/main/main.ts Show resolved Hide resolved
src/extension-host/extension-host.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@irahopkinson irahopkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you have auto-merge enabled. When I end up approving this PR it could merge before #43.

.vscode/launch.json Show resolved Hide resolved
.vscode/launch.json Show resolved Hide resolved
src/main/main.ts Show resolved Hide resolved
src/main/services/ServerNetworkConnector.ts Show resolved Hide resolved
src/main/main.ts Outdated Show resolved Hide resolved
src/main/main.ts Show resolved Hide resolved
Copy link
Contributor

@irahopkinson irahopkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

.vscode/launch.json Show resolved Hide resolved
@tjcouch-sil tjcouch-sil merged commit d5d933e into main Mar 8, 2023
@tjcouch-sil tjcouch-sil deleted the scaffold-core-extension-host branch March 8, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants