-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added extension host process that launches from main process #29
Conversation
…lers on disconnect and on reconnect, added ts-node configuration to support paths instead of having to supply command-line args for it
…ialize being run multiple times in some cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all your good work on this. I've done a first pass over this to keep it moving forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you have auto-merge enabled. When I end up approving this PR it could merge before #43.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
nodemon
{eh}
prefix and{/eh}
postfix%appdata%/paranext-core
src/client
folder for shared modules between the renderer and the extension hostsrc/node
folder for shared modules between main and extension hostClientNetworkConnector.ts
intoWebSocketFactory.ts
that loads browser WebSocket in renderer andws
's WebSocket in Node (extension host)Relates to #7 and #16