Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade TypeScript #263

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Upgrade TypeScript #263

merged 1 commit into from
Jun 22, 2023

Conversation

irahopkinson
Copy link
Contributor

@irahopkinson irahopkinson commented Jun 22, 2023

  • fix TSC error on Linux by upgrade to TS v5
  • fix building papi-components in TS v5
  • remove problem (and unneeded) typeRoot in tsconfig
  • also prettier some files found in linting

This change is Reviewable

- fix TSC error on Linux by upgrade to TS v5
- fix building `papi-components` in TS v5
- remove problem (and unneeded) typeRoot in tsconfig
- also prettier some files found in linting
@irahopkinson irahopkinson enabled auto-merge (squash) June 22, 2023 21:56
Copy link
Member

@lyonsil lyonsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 18 of 18 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @irahopkinson)

@irahopkinson irahopkinson merged commit 3148da0 into main Jun 22, 2023
6 checks passed
@irahopkinson irahopkinson deleted the upgrade-ts branch June 22, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants