Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menus: Update multi-column menu component to render menu based on JSON document as specified #424

Closed
lyonsil opened this issue Sep 11, 2023 · 3 comments
Assignees
Labels
extensions team Able to be worked on by extensions team

Comments

@lyonsil
Copy link
Member

lyonsil commented Sep 11, 2023

As a Platform.Bible extension developer, I want to be able to add menus to my webviews and contribute to extensible points in platform-provided menus.


This particular task is about having menu components that take a "final" menu JSON document for a multi-column menu and display the menus appropriately. The menu JSON document definition is in the menu contribution design document.

I'm told the existing mutli-column menu component already does something like this. It is important for the component to align with the schema from the design document, so some updates are likely needed.

Note that the items in a menu should be considered fixed while the menu is open/drawn on the screen. Once the menu is closed/hidden, its content should be reloaded before rendering again because extensions might have been enabled/disabled or something else might have changed that would modify the list of available menu items.

@lyonsil lyonsil added the extensions team Able to be worked on by extensions team label Sep 18, 2023
@lyonsil lyonsil changed the title Menus: Update menu component(s) to render menu based on JSON document as specified Menus: Update multi-column menu component(s) to render menu based on JSON document as specified Jan 12, 2024
@lyonsil lyonsil changed the title Menus: Update multi-column menu component(s) to render menu based on JSON document as specified Menus: Update multi-column menu component to render menu based on JSON document as specified Jan 12, 2024
@lyonsil lyonsil added this to the 2024-03 Q1 Milestone milestone Jan 12, 2024
@tjcouch-sil
Copy link
Member

You could probably quickly use a JSON-Schema-to-TS-types library to generate TS types for this from the JSON schema in the design quickly just this once :)

@tombogle
Copy link
Contributor

tombogle commented Mar 1, 2024

Small follow-on PR: #786

@tombogle
Copy link
Contributor

tombogle commented Mar 1, 2024

Another little PR to fix an issue in the (for now) hard-coded menu data: #787

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extensions team Able to be worked on by extensions team
Projects
Status: ✅ Done
Development

No branches or pull requests

5 participants