-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation of evm
crate to RISC-V in CI
#8240
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall, supportive, but this will require a few more iterations.
let's start with using default-features = false in root cargo.toml workspace dependencies, so we don't need path imports
I'd also prefer if we could do this in a smaller pr first that just focuses on this
@mattsse do you have a suggestion for what to do for this import |
looking into this |
Also do you have an recommendation of where to put the compilation to RISC-V test? I can put it in |
evm
crate to RISC-Vevm
crate to RISC-V in CI
By the way @mattsse these are the crates + methods from them that would be nice to have compiled to RISC-V:
In particular, we use the You can see the crates + method we use in this WIP draft PR I made here that implements a zkEVM STF using the crates above if that's helpful context. |
sp1_zkvm::entrypoint!(main); | ||
|
||
/// The main entrypoint for the zkVM program. | ||
pub fn main() {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this is supposed to be a placeholder, it needs better docs to explain that
This is an extremely messy WIP draft of the modifications needed to get the
reth_evm
crate to compile inside a zkVM. I put it up as a draft to get comments on the approach.