🔧 toil feedback refactor #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
========================================
+ Coverage 93.9% 100% +6.09%
========================================
Files 4 5 +1
Lines 164 219 +55
========================================
+ Hits 154 219 +65
+ Misses 10 0 -10
Continue to review full report at Codecov.
|
jsmedmar
changed the title
🔧 short long description for pypi
juanesarango
previously approved these changes
Feb 27, 2018
| if os.name == "posix" and sys.version_info[0] < 3: | ||
| import subprocess32 as subprocess | ||
| else: | ||
| import subprocess | ||
|
|
There was a problem hiding this comment.
got this from the subprocess32 github
juanesarango
approved these changes
Feb 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor was motivated by feedback from DataBiosphere/toil#2064 (comment):
docker.from_env(version='auto')workdirwas mapped to/tmpon singularity containersdef check_outputanddef check_call/dev/null