Docker and Cloudbuild fixes #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll be followed by some additional cleanup.
* Default image has tycho2 and 2mass index files for solving. * Dockerfile installs from pip.
Codecov Report
@@ Coverage Diff @@
## develop #1074 +/- ##
===========================================
+ Coverage 84.76% 86.39% +1.62%
===========================================
Files 77 78 +1
Lines 6531 6600 +69
Branches 560 560
===========================================
+ Hits 5536 5702 +166
+ Misses 836 733 -103
- Partials 159 165 +6
Continue to review full report at Codecov.
|
* Copy specific files into the Docker image. * Add ipython to the docker build environment file. * Simplify `pocs-cmd` (might just replace later).
* Removing unused bin script files.
* CMD is a simple ipython session. * Adding a basic script for loading POCS with all simulators. * Removing unused scripts.
* Removing `pocs` and `pocs-cmd` scripts.
* Tests are run in global mode so don't conflict if run twice at same time.
…all script. Other cleanup to script.
…tor. * Fixing incorrect `wait` call on `run` method. * Shortening some long debug statements. * Make example config file work with Docker images. * Skip pointing if `num_pointing_images==0`
* Adding `threading.excepthook` to log errors from camera threads.
* Small cleanup.
* Small cleanup.
* Small cleanup.
… to `0`. * Only include index file that is needed for tests. * Pointing doesn't try to correct itself in test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following changes in
panoptes-utils, this cleans up and simplifies the Docker services.Description
focuserdependencies.ipythonconsole with the simulators loaded.$PANDIR) is now/POCSwith other folders nested underneath.peasscripts.POCSinstance with all simulators.threading.excepthookto log errors in camera exposure threads. Addresses some of Unit tests not catching major problems #1047.num_pointing_images==0.gcr.io/panoptes-exp/panoptes-utilsas base.dockerfolder.config-serverandpocs-control) are started inglobalmode so there can be only one.tests/envfile.radiusfor solving images is 15°.Related Issue
Needed by #1071, #1072