Fixing onbuild #114
Fixing onbuild #114
Conversation
build.py
Outdated
| @@ -58,6 +58,8 @@ def docker_build(image_spec, path, build_args): | |||
| for k, v in build_args.items(): | |||
| command += ['--build-arg', f'{k}={v}'] | |||
| command.append(path) | |||
| # debug | |||
| print(command) | |||
| subprocess.check_call(command, shell=True) | |||
There was a problem hiding this comment.
@yuvipanda - I'm not getting any output from this call and the onbuild image isn't showing up. Any thoughts on what is going on here?
There was a problem hiding this comment.
|
Issue: We want to test building the base image and then have all other on-build images run as parallel jobs. Currently the base image builds, but is not among the local docker images for dependent jobs, nor is it currently pushed to a public access point, so we get failures like I'll try a solution which pushes base images to dockerhub with a temporary 'PR' tag modifier. Then when the PR is merged those images can be retagged and the 'PR' tags deleted. |
|
closing in favor of #118 |
No description provided.