Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning on Python 3.12 #54188

Closed
wants to merge 1 commit into from
Closed

Conversation

QuLogic
Copy link
Contributor

@QuLogic QuLogic commented Jul 19, 2023

Constant.n is now deprecated for removal in 3.14; it appears that Constant.value has existed since at least 3.9.

  • [n/a] closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • [n/a] Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

`Constant.n` is now deprecated for removal in 3.14; it appears that
`Constant.value` has existed since at least 3.9.
@mroeschke mroeschke added the expressions pd.eval, query label Jul 19, 2023
@mroeschke mroeschke added this to the 2.1 milestone Jul 19, 2023
@@ -550,7 +550,7 @@ def visit_Num(self, node, **kwargs) -> Term:
return self.const_type(node.n, self.env)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this one be changed too?

@lithomas1
Copy link
Member

lithomas1 commented Jul 19, 2023

I already have a PR for this #53743.

Thanks for the effort though.

@lithomas1 lithomas1 removed this from the 2.1 milestone Jul 19, 2023
@mroeschke
Copy link
Member

Thanks for the PR, but since this is covered in #53743 will close in favor of that PR

@mroeschke mroeschke closed this Jul 24, 2023
@QuLogic
Copy link
Contributor Author

QuLogic commented Jul 25, 2023

Oops, thought I looked for existing ones; not sure why I didn't find it earlier.

@QuLogic QuLogic deleted the py312 branch July 25, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
expressions pd.eval, query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants