chore: ignore claims behind last observed nonce #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we ever reset the latest skyway nonce ahead of any observed claim, we don't need nor want pigeons trying to attest to them. So, we can filter claims that are behind the latest attested claim.
maharifu
force-pushed
the
fix/filter_claims_behind_last_nonce
branch
from
b514136
to
b052b1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Github tickets
Background
If we ever reset the latest skyway nonce ahead of any observed claim, we don't need nor want pigeons trying to attest to them. So, we can filter claims that are behind the latest attested claim.
This should prevent pigeons from getting stuck trying to get old claims if their RPC fails, and we need to reset the nonce ahead of observed claims.
Testing completed
Breaking changes