Fix/pigeons attest rolledback txs #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maharifu
force-pushed
the
fix/pigeons_attest_rolledback_txs
branch
from
f8c0c3e
to
6bcac66
Compare
byte-bandit
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Github tickets
Background
Paloma was attesting to pigeon relayed messages using only the transaction, but not the receipt, meaning it couldn't actually attest the transaction was successful. This (and a corresponding PR in pigeon) makes paloma verify the transaction result from the transaction receipt and only attest to successful transactions.
Validated with an SLC message in the private testnet using Gnosis, but the result should be the same for all turnstone messages. This wasn't replicable in Arbitrum, where messages fail immediately on pigeons.
Also in this PR is a fix for SLC and User Smart Contract Upload retries. We need to clear the Fees from the message before a retry, otherwise we get an Invalid Signature error.
Testing completed
Breaking changes