Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add #1275

Merged
merged 8 commits into from
Aug 27, 2024
Merged

Add #1275

merged 8 commits into from
Aug 27, 2024

Conversation

byte-bandit
Copy link
Contributor

@byte-bandit byte-bandit commented Aug 27, 2024 •
edited
Loading

Related Github tickets

Background

  • Fixes the Skyway nonce reset implementation during a compass ugprade
  • Introduces a governance proposal message which may be used to override the last nonce across all validators for a given chain to recover from a desync

Testing completed

  • test coverage exists or has been added/updated
  • tested in a private testnet

Breaking changes

  • I have checked my code for breaking changes
  • If there are breaking changes, there is a supporting migration.

byte-bandit
byte-bandit commented Aug 27, 2024
View reviewed changes
x/skyway/abci.go Outdated Show resolved Hide resolved
@byte-bandit byte-bandit marked this pull request as draft August 27, 2024 16:15
@byte-bandit byte-bandit marked this pull request as ready for review August 27, 2024 16:16
taariq
taariq approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@taariq taariq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG!

@taariq taariq merged commit f285510 into palomachain:master Aug 27, 2024
3 checks passed
@taariq taariq deleted the clohr/debug branch August 27, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taariq taariq taariq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byte-bandit @taariq