fix: prevent stuck SLCs waiting for valset #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maharifu
force-pushed
the
fix/1040-valset-update-watchdog
branch
from
e90b543
to
c32b14a
Compare
byte-bandit
force-pushed
the
fix/1040-valset-update-watchdog
branch
from
7795605
to
32cf9fc
Compare
byte-bandit
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Github tickets
Background
If a JIT ValsetUpdate fails, it can lead to SLC messages being stuck. In order to overcome this, we set a watcher on the end blocker to insert new ValsetUpdates when needed if there is an SLC message in the queue (or UploadUserSmartContract message).
Testing completed
Breaking changes