Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

[new-rule-option] Introduce new typedef rule option (variable-declaration-ignore-function) #4769

Merged
merged 5 commits into from
Jul 4, 2019

Conversation

michaelw85
Copy link
Contributor

PR checklist

Overview of change:

Add new option for typedef rule.
Ignores typedef requirement for vars for arrow and non arrow functions.

CHANGELOG.md entry:

[new-rule-option] typedef new option: variable-declaration-ignore-function

Ignores typedef requirement for vars for arrow and non arrow functions.

Fixes: palantir#2654
@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @michaelw85! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@michaelw85
Copy link
Contributor Author

@JoshuaKGoldberg Could you review this PR or do you know anyone who would be able to?

@JoshuaKGoldberg
Copy link
Contributor

Hi yes, sorry for the delay! I will soon 🙂.

For context, both adidahiya and I are maintaining TSLint in roughly part time amounts. There's also a lot of ongoing work for migrating to ESLint. So this might take a few days more.

@michaelw85
Copy link
Contributor Author

@JoshuaKGoldberg Thanks for the reply. Don't worry there is no rush (for me) although I would definitely be happy to have this feature. I wasn't sure if anyone noticed the PR so I thought I would tag you since you categorized the linked feature request.

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source code looks good to me! Just waiting on test changes.

@michaelw85
Copy link
Contributor Author

@JoshuaKGoldberg PR is updated! Thanks for reviewing.

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR @michaelw85!

@JoshuaKGoldberg
Copy link
Contributor

testNext failures are unrelated; will file a separate issue.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 1d5d624 into palantir:master Jul 4, 2019
@michaelw85 michaelw85 deleted the 2654_arrow_func_typedef branch July 4, 2019 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants