NPM plugin #70
Merged
NPM plugin #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CapitalizationPreview: docs |
use dm.relativePathPreview: docs |
use relativePath in markdown pluginPreview: docs |
src/launch.ts
Outdated
| @@ -15,7 +16,9 @@ import { TypescriptPlugin } from "./plugins/typescript"; | |||
| // Set breakpoints in original .ts source and debug in the editor! | |||
| Documentalist.create() | |||
| .use(".ts", new TypescriptPlugin()) | |||
| .use(".json", new NpmPlugin()) | |||
There was a problem hiding this comment.
this is too broad, it should only apply to package.jsons.
src/plugins/npm.ts
Outdated
| name: data.name, | ||
| // tslint:disable-next-line:object-literal-sort-keys | ||
| description: data.description, | ||
| latestVersion: data["dist-tags"].latest, |
There was a problem hiding this comment.
is this guaranteed to be non-null? what about not-yet released libraries?
There was a problem hiding this comment.
yes good catch. un-released libraries will actually die here because npm info will return nothing
added 2 commits
June 19, 2018 15:35
add private/published properties to npm package, add excludeNames/excludePrivate optionsPreview: docs |
themadcreator
approved these changes
Jun 19, 2018
commentPreview: docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sourceBaseDiroption forDocumentalistcontrols relative pathing forsourcePathin MD and NPMNpmPlugin!excludePrivate,excludePathsoptionsnpm infoif possible (async call to npm registry)