Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 401 Unauthenticated to conjure error types #367

Merged
merged 2 commits into from
Oct 14, 2019
Merged

Add 401 Unauthenticated to conjure error types #367

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47aaffb
Add 401 Unauthenticated
Aug 22, 2019
7343994
Reorder
Aug 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions conjure-api/src/main/conjure/conjure-api.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ types:
alias: string
ErrorCode:
values:
- UNAUTHENTICATED
- PERMISSION_DENIED
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a change to the IR - I think we now need to figure out our IR versioning story pronto before we cut any releases.

- INVALID_ARGUMENT
- NOT_FOUND
Expand Down
1 change: 1 addition & 0 deletions docs/spec/conjure_definitions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,7 @@ docs | [DocString][] | Documentation for the type. [CommonMark syntax](http://sp
## ErrorCode
[ErrorCode]: #errorcode
A field describing the error category. MUST be one of the following strings, with HTTP status codes defined in the [wire spec](/docs/spec/wire.md#34-conjure-errors):
* UNAUTHENTICATED
* PERMISSION_DENIED
* INVALID_ARGUMENT
* NOT_FOUND
Expand Down
1 change: 1 addition & 0 deletions docs/spec/wire.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@ In order to send a Conjure error, servers must serialize the error using the [JS

Conjure Error code | HTTP Status code |
-------------------------- | ---------------- |
UNAUTHENTICATED | 401
PERMISSION_DENIED | 403
INVALID_ARGUMENT | 400
NOT_FOUND | 404
amrav marked this conversation as resolved.
Show resolved Hide resolved
Expand Down