Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codegen for map<T, double> #302

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Fix codegen for map<T, double> #302

merged 2 commits into from
Feb 15, 2024

Conversation

sfackler
Copy link
Member

Closes #301

@changelog-app
Copy link

changelog-app bot commented Feb 15, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Fix codegen for map<T, double>

Check the box to generate changelog(s)

  • Generate changelog entry

@sfackler sfackler merged commit a883c40 into master Feb 15, 2024
5 checks passed
@sfackler sfackler deleted the map-double branch February 15, 2024 14:51
sfackler added a commit that referenced this pull request Feb 15, 2024
Fix codegen for map<T, double>

(cherry picked from commit a883c40)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

map<T, double> isn't handled properly
3 participants