Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CI version #300

Merged
merged 3 commits into from
Feb 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ orbs:

executors:
rust:
docker: [{ image: rust:1.65.0 }]
docker: [{ image: rust:1.75.0 }]

commands:
restore_target:
Expand Down
5 changes: 5 additions & 0 deletions changelog/@unreleased/pr-300.v2.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
type: feature
feature:
description: Fix the build
links:
- https://github.com/palantir/conjure-rust/pull/300
2 changes: 1 addition & 1 deletion conjure-codegen/src/context.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1091,7 +1091,7 @@ impl Context {
.cloned()
.or_else(|| self.type_log_safety(f.type_()))
})
.fold(Some(LogSafety::Safe), |a, b| self.combine_safety(a, b)),
.try_fold(LogSafety::Safe, |a, b| self.combine_safety(Some(a), b)),
TypeDefinition::Union(union_) => union_
.union_()
.iter()
Expand Down
7 changes: 5 additions & 2 deletions conjure-macros/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,8 @@ fn add_path_components(
Error::new_spanned(
path_lit,
format_args!("invalid path parameter `{param}`"),
).into_compile_error(),
)
.into_compile_error(),
);
continue;
};
Expand Down Expand Up @@ -731,7 +732,9 @@ struct BodyAttr {
impl ArgType {
fn new(arg: &mut FnArg) -> syn::Result<Option<Self>> {
// Ignore the self arg.
let FnArg::Typed(pat_type) = arg else { return Ok(None); };
let FnArg::Typed(pat_type) = arg else {
return Ok(None);
};

// FIXME we should probably just rename the arguments in our impl?
let ident = match &*pat_type.pat {
Expand Down
2 changes: 1 addition & 1 deletion conjure-object/src/double_key.rs
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ impl DerefMut for DoubleKey {
impl PartialOrd for DoubleKey {
#[inline]
fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
OrderedFloat(self.0).partial_cmp(&OrderedFloat(other.0))
Some(self.cmp(other))
}
}

Expand Down
2 changes: 1 addition & 1 deletion conjure-object/src/resource_identifier/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ impl Eq for ResourceIdentifier {}
impl PartialOrd for ResourceIdentifier {
#[inline]
fn partial_cmp(&self, other: &ResourceIdentifier) -> Option<Ordering> {
self.rid.partial_cmp(&other.rid)
Some(self.cmp(other))
}

#[inline]
Expand Down
4 changes: 2 additions & 2 deletions conjure-test/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@
#[cfg(test)]
mod test;

#[allow(dead_code, clippy::all)]
#[allow(dead_code, unused_imports, clippy::all)]
mod types {
include!(concat!(env!("OUT_DIR"), "/conjure/mod.rs"));
}

#[allow(dead_code, clippy::all)]
#[allow(dead_code, unused_imports, clippy::all)]
mod staged_types {
include!(concat!(env!("OUT_DIR"), "/conjure-staged/mod.rs"));
}
6 changes: 3 additions & 3 deletions example-api/Cargo.toml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.