fix build

palantir · Feb 14, 2024 · 9f4ce72 · 9f4ce72
1 parent 408e1e2
commit 9f4ce72
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/changelog/@unreleased/pr-300.v2.yml b/changelog/@unreleased/pr-300.v2.yml
@@ -0,0 +1,5 @@
+type: feature
+feature:
+  description: Fix the build
+  links:
+  - https://github.com/palantir/conjure-rust/pull/300
diff --git a/conjure-codegen/src/context.rs b/conjure-codegen/src/context.rs
@@ -1091,7 +1091,7 @@ impl Context {
                         .cloned()
                         .or_else(|| self.type_log_safety(f.type_()))
                 })
-                .fold(Some(LogSafety::Safe), |a, b| self.combine_safety(a, b)),
+                .try_fold(LogSafety::Safe, |a, b| self.combine_safety(Some(a), b)),
             TypeDefinition::Union(union_) => union_
                 .union_()
                 .iter()

diff --git a/conjure-object/src/double_key.rs b/conjure-object/src/double_key.rs
@@ -57,7 +57,7 @@ impl DerefMut for DoubleKey {
 impl PartialOrd for DoubleKey {
     #[inline]
     fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
-        OrderedFloat(self.0).partial_cmp(&OrderedFloat(other.0))
+        Some(self.cmp(other))
     }
 }
 

diff --git a/conjure-object/src/resource_identifier/mod.rs b/conjure-object/src/resource_identifier/mod.rs
@@ -217,7 +217,7 @@ impl Eq for ResourceIdentifier {}
 impl PartialOrd for ResourceIdentifier {
     #[inline]
     fn partial_cmp(&self, other: &ResourceIdentifier) -> Option<Ordering> {
-        self.rid.partial_cmp(&other.rid)
+        Some(self.cmp(other))
     }
 
     #[inline]