Drop runtime dependency on setuptools #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hroncok
force-pushed
the
importlib_metadata
branch
from
12bfdd3
to
62865c6
Compare
|
I am not sure I understand the mypy failure. Should I noqa it? |
It seems to be a known issue: python/mypy#1153 |
hroncok
force-pushed
the
importlib_metadata
branch
from
62865c6
to
d07ce14
Compare
|
Added |
|
But the pre-commit thing now made it uglier :( |
The setuptools package is a huge overkill to get self-version. Use the standard library instead on Python 3.8+, or a smaller package on older Pythons.
Verified 3.10 support by running the tests in Fedora Rawhide. Assuming Python 3.9 support as well.
hroncok
force-pushed
the
importlib_metadata
branch
from
e69b9d5
to
7f52843
Compare
|
I've tried really hard to make it both readable and acceptable by the robot overlords. |
|
Very nice, I didn't know there is a more lightweight way to do this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setuptools package is a huge overkill to get self-version.
Use the standard library instead on Python 3.8+,
or a smaller package on older Pythons.
Declare support for new Pythons (extra commit).