Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop python<=3.7 support #390

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

drop python<=3.7 support #390

wants to merge 2 commits into from

Conversation

kloczek
Copy link

@kloczek kloczek commented Jun 26, 2024

According to https://endoflife.date/python python 3.7 has been EOSed 27 Jun 2023.
Filter all code over pyupgracde --py38-plus.

TODO:

  • Write new tests or update the old ones to cover new functionality.
  • Update doc-strings where appropriate.
  • Update or write new documentation in packit/packit.dev.
  • ‹fill in›

Fixes

Related to

Merge before/after

RELEASE NOTES BEGIN

Packit now supports automatic ordering of ☕ after all checks pass.

RELEASE NOTES END

kloczek and others added 2 commits June 26, 2024 13:13
According to https://endoflife.date/python python 3.7 has been
EOSed 27 Jun 2023.
Filter all code over `pyupgracde --py38-plus`.

Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/43c3d618d74840aa821249c34f55698f

✔️ pre-commit SUCCESS in 2m 19s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 21s
✔️ specfile-tests-pip-deps SUCCESS in 1m 16s

@nforro
Copy link
Member

nforro commented Jun 26, 2024

Upstream may not support Python 3.7 and older versions anymore, but Red Hat supports Python 3.6 in RHEL 8 and this library is still being built for EPEL 8.

@kloczek
Copy link
Author

kloczek commented Jun 26, 2024

I don't think that it will be possible to hold that support integrated in master code until 2029 (when EPEL 8 will be EOLed).

IMO better would be just assume that it it will be any critical issue in last used by EPEL 8 version always it can be used last release ta to create branch -> apply necessary fix -> release fixed legacy version.
Many fast moving python modules already is using that strategy and it allow to keep on master support for only >=3.9 or even >=3.11.

Man/hours overhead on some additional commits in possible legacy branches is usually negligible. At the same time it allows keep very clean/smaller code on master.

@kloczek kloczek changed the title drop python<3=3.7 support drop python<=3.7 support Jun 26, 2024
@nforro
Copy link
Member

nforro commented Jul 25, 2024

Good point. But in that case I'd rather drop 3.7 and 3.8 as well, supporting 3.9+ would allow for code simplification in some places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants