Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functional test to parse all Fedora spec files #237

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add functional test to parse all Fedora spec files #237

wants to merge 3 commits into from

Conversation

nforro
Copy link
Member

@nforro nforro commented Jun 11, 2023

Inspired by #235.

@nforro
Be explicit about encoding
c5dce21 
Default encoding is not always UTF-8, make it explicit. Also use
the surrogateescape error handler to preserve undecodable bytes.

Signed-off-by: Nikola Forró <nforro@redhat.com>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/41c49cb8108248d493e88ad67bbb89a8

✔️ pre-commit SUCCESS in 1m 51s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 06s
✔️ specfile-tests-pip-deps SUCCESS in 1m 07s

@mfocko
Copy link
Member

mfocko commented Jun 11, 2023 •
edited
Loading 

================ 2812 failed, 20192 passed in 968.78s (0:16:08) ================

Are you planning on fixing it? 👀 anyways 12.22% isn't that bad \o/

@nforro
Copy link
Member Author

nforro commented Jun 11, 2023

It will go down to about 10 failures once I figure out and install all the macro packages that are necessary for parsing 🙂

@mfocko
Copy link
Member

mfocko commented Jun 11, 2023

Ah sure, it seemed like there are some “clusters”, I think Go was one of those?

@nforro
Copy link
Member Author

nforro commented Jun 11, 2023

Yes. Let's see now.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/5fa1244cfd484ebf881b7f9b0e39b6b9

✔️ pre-commit SUCCESS in 1m 48s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 05s
✔️ specfile-tests-pip-deps SUCCESS in 1m 01s

@nforro
Copy link
Member Author

nforro commented Jun 12, 2023

Ok, rpm-software-management/rpm@b3adc8c explains the higher number of failures on rawhide. As for the rest, some of them are bugs (and for some of those there are already issues reported, thanks @xsuchy) and a few of them are packaging errors, I'll try to find a way to differentiate those.

xsuchy
xsuchy reviewed Jun 12, 2023
View reviewed changes
tests/functional.fmf Outdated Show resolved Hide resolved
@nforro
Add functional test to parse all Fedora spec files
7771658 
Signed-off-by: Nikola Forró <nforro@redhat.com>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/22d2b16208f14d7799970235760c653f

✔️ pre-commit SUCCESS in 1m 44s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 10s
✔️ specfile-tests-pip-deps SUCCESS in 56s

@nforro
Fix a trivial bug in section parsing
5e7c8ab 
Signed-off-by: Nikola Forró <nforro@redhat.com>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/5107d6b3321d4eb2a6480e4eaadb73b2

✔️ pre-commit SUCCESS in 1m 46s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 04s
✔️ specfile-tests-pip-deps SUCCESS in 1m 02s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xsuchy xsuchy xsuchy left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nforro @mfocko @xsuchy