Use a build matrix for Docker workflows #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to trigger the release/deploy job for each matrix execution. It must be triggered only once when all builds have finished.
okiedork
force-pushed
the
improv/workflows-matrix
branch
from
9935053
to
8a6e9bf
Compare
flavioheleno
approved these changes
Jul 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
In this PR I've made two changes:
1. Added a build matrix to Docker builds
I had to change
nginx.Dockerfilein order to accommodate the build target argument. The matrix is built with configuration expansion (doc).2. Split the workflow in two
This is a revert of 65a5997, because we don't want to trigger the release/deploy task for all matrix configurations. The job will run only once, after all builds are completed with success.
You can check an example of the workflow in this manually triggered run: https://github.com/package-health/php/actions/runs/2762273790