Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loc_t::operator< when parent is nullptr #4798

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Fix loc_t::operator< when parent is nullptr #4798

merged 1 commit into from
Jul 12, 2024

Conversation

kfcripps
Copy link
Contributor

Found while working on #4797: Bad things will happen in loc_t::operator< when parent is nullptr.

@kfcripps kfcripps requested review from grg and ChrisDodd July 12, 2024 17:28
@kfcripps
Fix loc_t operator< when parent is nullptr
0c9db9a 
Signed-off-by: Kyle Cripps <kyle@pensando.io>
grg
grg approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@grg grg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kfcripps kfcripps added this pull request to the merge queue Jul 12, 2024
Merged via the queue into p4lang:main with commit a258b7e Jul 12, 2024
17 checks passed
@kfcripps kfcripps deleted the fix-loc_t branch July 12, 2024 23:41
@fruffy fruffy added the core Topics concerning the core segments of the compiler (frontend, midend, parser) label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grg grg grg approved these changes

@ChrisDodd ChrisDodd ChrisDodd approved these changes

Assignees
No one assigned
Labels
core Topics concerning the core segments of the compiler (frontend, midend, parser)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kfcripps @grg @ChrisDodd @fruffy