Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some stale DPDK error reference files. #4705

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Jun 3, 2024

Also make sure that the dpdk test runner throws an error when the reference file is stale.

Looks like there was some regression in the error messages, but I do not know how to fix these.

This is yak shaving needed for #4683.

@fruffy fruffy added the dpdk Topics related to the DPDK back end label Jun 3, 2024
@fruffy fruffy requested a review from jafingerhut June 3, 2024 21:49
@fruffy fruffy changed the title Update some stale DPDK reference files. Update some stale DPDK error reference files. Jun 3, 2024
@jafingerhut
Copy link
Contributor

@usha1830 @Sosutha Could one of you review this?

@jafingerhut
Copy link
Contributor

@fruffy I am not sure of the history of these test programs, but I did notice that several of the ones updated here instantiate an extern called ipsec_accelerator, which is defined in p4c/include/dpdk/pna.p4, but not in p4c/include/pna.p4.

Perhaps a better change would be to update those test programs mentioning ipsec_accelerator to replace #include <pna.p4> with #include <dpdk/pna.p4> ?

…runner throws an error when the reference file is stale.
@fruffy
Copy link
Collaborator Author

fruffy commented Jun 4, 2024

@fruffy I am not sure of the history of these test programs, but I did notice that several of the ones updated here instantiate an extern called ipsec_accelerator, which is defined in p4c/include/dpdk/pna.p4, but not in p4c/include/pna.p4.

Perhaps a better change would be to update those test programs mentioning ipsec_accelerator to replace #include <pna.p4> with #include <dpdk/pna.p4> ?

Thanks for the tip, updated the include headers for some of the files and it looks like that was a reason for the regression.

Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jafingerhut jafingerhut added this pull request to the merge queue Jun 4, 2024
Merged via the queue into main with commit d5df09b Jun 4, 2024
17 checks passed
@jafingerhut jafingerhut deleted the fruffy/dpdk_state_ref branch June 4, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dpdk Topics related to the DPDK back end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants