Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly include hash.hpp for Ubuntu 18.04. #4664

Merged
merged 1 commit into from
May 17, 2024
Merged

Explicitly include hash.hpp for Ubuntu 18.04. #4664

merged 1 commit into from
May 17, 2024

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented May 13, 2024 •
edited
Loading

A workaround until #4663 is ready. Fixes #4659.

@fruffy fruffy added the run-ubuntu18 Use this tag to trigger a Ubuntu-18 CI run. label May 13, 2024
@fruffy fruffy marked this pull request as ready for review May 14, 2024 00:28
@fruffy fruffy changed the title Explicitly include hash_fwd for Ubuntu 18.04. Explicitly include hash.hpp for Ubuntu 18.04. May 14, 2024
vlstill
vlstill approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@vlstill vlstill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the version check? If the file exists in newer boost, maybe we could include it always.

@fruffy
Copy link
Collaborator Author

fruffy commented May 17, 2024 •
edited
Loading

Do we need the version check? If the file exists in newer boost, maybe we could include it always.

I'd prefer to keep the unnecessary boost includes to a minimum. In this particular case, boost/functional/hash.hpp was changed to boost/container_hash/hash.hpp

https://www.boost.org/doc/libs/1_72_0/doc/html/hash/changes.html#hash.changes.boost_1_67_0

@fruffy fruffy added this pull request to the merge queue May 17, 2024
@fruffy fruffy added the core Topics concerning the core segments of the compiler (frontend, midend, parser) label May 17, 2024
Merged via the queue into main with commit 6efb5ec May 17, 2024
17 checks passed
@fruffy fruffy deleted the fruffy/boost_fwd branch May 17, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlstill vlstill vlstill approved these changes

@asl asl Awaiting requested review from asl

@ChrisDodd ChrisDodd Awaiting requested review from ChrisDodd

@jafingerhut jafingerhut Awaiting requested review from jafingerhut

Assignees
No one assigned
Labels
core Topics concerning the core segments of the compiler (frontend, midend, parser) run-ubuntu18 Use this tag to trigger a Ubuntu-18 CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix broken Ubuntu 18.04 test by pinning Boost dependencies using FetchContent
2 participants
@fruffy @vlstill