Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spurious failure when two tests try to remove ptf.log at the same time. #4591

Merged
merged 1 commit into from
Apr 3, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion backends/bmv2/run-bmv2-ptf-test.py
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,11 @@ def run_ptf(self, grpc_port: int, json_name: Path, info_name: Path) -> int:
# Add the tools PTF folder to the python path, it contains the base test.
pypath = ROOT_DIR.joinpath("tools/ptf")
# Show list of the tests
test_list_cmd = f"ptf --pypath {pypath} --test-dir {self.options.testdir} --list"
test_list_cmd = (
f"ptf --pypath {pypath} "
f"--log-file {self.options.testdir.joinpath('ptf.log')} "
f"--test-dir {self.options.testdir} --list"
)
returncode = self.bridge.ns_exec(test_list_cmd)
if returncode != testutils.SUCCESS:
return returncode
Expand Down
Loading